Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2942513002: Allow banners to trigger on sites which don't register a service worker onload. (Closed)
Patch Set: Fix windows compile Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index 183bd0ead07195a7f3184d5cbf0ea8e984aed5df..c5710ae8fca6368cc0d417096e971eba4d9c3594 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -94,6 +94,9 @@ public class AppBannerManagerTest {
private static final String WEB_APP_PATH =
"/chrome/test/data/banners/manifest_test_page.html";
+ private static final String LAZY_SERVICE_WORKER_PATH =
+ "/chrome/test/data/banners/lazy_service_worker_test_page.html";
+
private static final String WEB_APP_SHORT_TITLE_MANIFEST =
"/chrome/test/data/banners/manifest_short_name_only.json";
@@ -629,6 +632,13 @@ public class AppBannerManagerTest {
WEB_APP_SHORT_TITLE, false);
}
+ @Test
+ @SmallTest
+ @Feature({"AppBanners"})
+ public void testBannerTriggersWithLazyServiceWorker() throws Exception {
+ triggerWebAppBanner(mTestServer.getURL(LAZY_SERVICE_WORKER_PATH), WEB_APP_TITLE, false);
+ }
+
@Test
@SmallTest
@Feature({"AppBanners"})
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.h » ('j') | chrome/browser/banners/app_banner_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698