Allow banners to trigger on sites which don't register a service worker onload.

chrome/browser/banners/app_banner_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 #define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 
 #include <vector>
 
 #include "base/macros.h"
@@ skipping 83 matching lines @@
   virtual void OnAppIconFetched(const SkBitmap& bitmap) {}
 
  protected:
   enum class State {
     // The banner pipeline has not yet been triggered for this page load.
     INACTIVE,
 
     // The banner pipeline is currently running for this page load.
     ACTIVE,
 
+    // The banner pipeline is currently waiting for the page manifest to be
+    // fetched.
+    PENDING_MANIFEST,
+
+    // The banner pipeline is currently waiting for the installability criteria
+    // to be checked.
+    PENDING_INSTALLABLE_CHECK,
+
     // The banner pipeline has finished running, but is waiting for sufficient
     // engagement to trigger the banner.
     PENDING_ENGAGEMENT,
 
     // The banner pipeline has finished running, but is waiting for an event to
     // trigger the banner.
     PENDING_EVENT,
 
     // The banner pipeline has finished running for this page load and no more
     // processing is to be done.
@@ skipping 91 matching lines @@
   void OnEngagementIncreased(content::WebContents* web_contents,
                              const GURL& url,
                              double score) override;
 
   // Subclass accessors for private fields which should not be changed outside
   // this class.
   InstallableManager* manager() const { return manager_; }
   int event_request_id() const { return event_request_id_; }
   bool is_active() const { return state_ == State::ACTIVE; }
   bool is_active_or_pending() const {
-    return state_ == State::ACTIVE || state_ == State::PENDING_ENGAGEMENT ||
-           state_ == State::PENDING_EVENT;
+    switch (state_) {
+      case State::ACTIVE:
+      case State::PENDING_MANIFEST:
+      case State::PENDING_INSTALLABLE_CHECK:
+      case State::PENDING_ENGAGEMENT:
+      case State::PENDING_EVENT:
+        return true;
+      case State::INACTIVE:
+      case State::COMPLETE:
+        return false;
+    }
+    return false;
   }
   bool is_complete() const { return state_ == State::COMPLETE; }
   bool is_pending_engagement() const {
     return state_ == State::PENDING_ENGAGEMENT;
   }
   bool is_pending_event() const {
     return state_ == State::PENDING_EVENT || page_requested_prompt_;
   }
 
   // The title to display in the banner.
@@ skipping 78 matching lines @@
   // scoped to the WebContents which they are observing. This allows us to use
   // weak pointers for callbacks.
   base::WeakPtrFactory<AppBannerManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerManager);
 };
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_