Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2942433002: Cleanup some unused code in some of the tests (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -182 lines) Patch
M pkg/analysis_server/test/abstract_context.dart View 5 chunks +17 lines, -70 lines 0 comments Download
M pkg/analysis_server/test/abstract_single_unit.dart View 2 chunks +13 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 19 chunks +0 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart View 2 chunks +1 line, -8 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 2 chunks +3 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 11 chunks +20 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
One of the `enableNewAnalysisDriver` getters is no longer being used, so it and some other ...
3 years, 6 months ago (2017-06-13 19:36:47 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-13 19:42:57 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-13 21:01:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4337a3aeeeeee550c087b48e66118cb978a51c7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698