Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: services/resource_coordinator/coordination_unit/coordination_unit_manager.h

Issue 2942403002: [GRC] Coordination Unit Graph Observer (Closed)
Patch Set: Fix unittest and OnCoordinationUnitWillBeDestroyed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/coordination_unit/coordination_unit_manager.h
diff --git a/services/resource_coordinator/coordination_unit/coordination_unit_manager.h b/services/resource_coordinator/coordination_unit/coordination_unit_manager.h
index 0907d05e2a52a32fe9176d8586f6719268d356ed..447da5711be3b3b3bede5f4ee86b15037c25aaa9 100644
--- a/services/resource_coordinator/coordination_unit/coordination_unit_manager.h
+++ b/services/resource_coordinator/coordination_unit/coordination_unit_manager.h
@@ -21,7 +21,7 @@ class CoordinationUnitImpl;
class CoordinationUnitGraphObserver;
// The CoordinationUnitManager is a singleton that encapsulates all
-// aspects of Coordination Units within the ResourceCoordinatorService.
+// aspects of Coordination Units within the resource_coordinator service.
// All functionality for dealing with CoordinationUnits should be contained
// within this class or classes that are owned by it
class CoordinationUnitManager {
@@ -32,13 +32,15 @@ class CoordinationUnitManager {
void OnStart(service_manager::BinderRegistry* registry,
service_manager::ServiceContextRefFactory* service_ref_factory);
void RegisterObserver(
- std::unique_ptr<CoordinationUnitGraphObserver> observers);
-
- void NotifyObserversCoordinationUnitCreated(
- CoordinationUnitImpl* coordination_unit);
- void NotifyObserversCoordinationUnitWillBeDestroyed(
+ std::unique_ptr<CoordinationUnitGraphObserver> observer);
+ void OnCoordinationUnitCreated(CoordinationUnitImpl* coordination_unit);
+ void OnCoordinationUnitWillBeDestroyed(
CoordinationUnitImpl* coordination_unit);
+ std::vector<std::unique_ptr<CoordinationUnitGraphObserver>>& observers() {
oystein (OOO til 10th of July) 2017/06/20 21:39:33 nit: looks this is just for testing? maybe const s
+ return observers_;
+ }
+
private:
std::vector<std::unique_ptr<CoordinationUnitGraphObserver>> observers_;

Powered by Google App Engine
This is Rietveld 408576698