Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.cc

Issue 2942403002: [GRC] Coordination Unit Graph Observer (Closed)
Patch Set: Fix unittest and OnCoordinationUnitWillBeDestroyed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.cc
diff --git a/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.cc b/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.cc
index c4214ebfa61ed72df2806fadc29e666093856537..fc69dab319b771a5bd274e4a3b3aaa2bd7140b0e 100644
--- a/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.cc
+++ b/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.cc
@@ -8,24 +8,8 @@
namespace resource_coordinator {
-// Setting filter_ to CoordinationUnitType::kInvalidType bypasses the
-// filtering used to determine whether or not
-// CoordinationUnitGraphObserver::CoordinationUnitCreated should be invoked
-// when a new CoordinationUnitImpl is created in the CoordinationUnitManager.
-CoordinationUnitGraphObserver::CoordinationUnitGraphObserver()
- : filter_(CoordinationUnitType::kInvalidType) {}
-
-CoordinationUnitGraphObserver::CoordinationUnitGraphObserver(
- CoordinationUnitType filter)
- : filter_(filter) {}
+CoordinationUnitGraphObserver::CoordinationUnitGraphObserver() = default;
CoordinationUnitGraphObserver::~CoordinationUnitGraphObserver() = default;
-bool CoordinationUnitGraphObserver::ShouldObserve(
- CoordinationUnitImpl* coordination_unit) {
- // CoordinationUnitType::kInvalidType overrides filtering.
- return filter_ == CoordinationUnitType::kInvalidType ||
- filter_ == coordination_unit->id().type;
-}
-
} // namespace resource_coordinator

Powered by Google App Engine
This is Rietveld 408576698