tools/telemetry/telemetry/page/actions/wait.py - Issue 29423005: telemetry: Add GetRendererProcessFromTab to timeline model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/wait.py

Issue 29423005: telemetry: Add GetRendererProcessFromTab to timeline model. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update unit test. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/actions/wait.py

diff --git a/tools/telemetry/telemetry/page/actions/wait.py b/tools/telemetry/telemetry/page/actions/wait.py

index 3689a2b7a703101a8d378a8f90cc0c03954a1a27..92d82f9c90651d9cb9d330ac3fdaa43fb0ef2c96 100644

--- a/tools/telemetry/telemetry/page/actions/wait.py

+++ b/tools/telemetry/telemetry/page/actions/wait.py

@@ -19,7 +19,7 @@ class WaitAction(page_action.PageAction):

def RunAction(self, page, tab, previous_action):

tab.ExecuteJavaScript(

- 'console.time("' + self.GetTimelineMarkerLabel() + '")')

+ 'console.time("' + self.GetTimelineMarkerName() + '")')

if hasattr(self, 'seconds'):

time.sleep(self.seconds)

@@ -69,7 +69,7 @@ class WaitAction(page_action.PageAction):

raise page_action.PageActionFailed('No wait condition found')

tab.ExecuteJavaScript(

- 'console.timeEnd("' + self.GetTimelineMarkerLabel() + '")')

+ 'console.timeEnd("' + self.GetTimelineMarkerName() + '")')

- def GetTimelineMarkerLabel(self):

+ def GetTimelineMarkerName(self):

return 'WaitAction::RunAction'

« no previous file with comments | « tools/telemetry/telemetry/page/actions/scroll.py ('k') | no next file » | no next file with comments »