Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py

Issue 29423005: telemetry: Add GetRendererProcessFromTab to timeline model. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update unit test. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py
index b2b0fa3591a424f8dd4c75b994343b585f72ef91..c9a182fb1f49460a0c953be218ccb213c8458ce6 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py
@@ -80,26 +80,26 @@ class TracingBackendTest(tab_test_case.TabTestCase):
# is implemented (crbug.com/173327).
-class TracingResultImplTest(unittest.TestCase):
+class ChromeTraceResultTest(unittest.TestCase):
# Override TestCase.run to run a test with all possible
- # implementations of TraceResult.
+ # implementations of ChromeTraceResult.
def __init__(self, method_name):
- self._traceResultImplClass = None
- super(TracingResultImplTest, self).__init__(method_name)
+ self._chromeTraceResultClass = None
+ super(ChromeTraceResultTest, self).__init__(method_name)
def run(self, result=None):
- def RawTraceResultImplWrapper(strings):
- return tracing_backend.RawTraceResultImpl(map(json.loads, strings))
+ def ChromeRawTraceResultWrapper(strings):
+ return tracing_backend.ChromeRawTraceResult(map(json.loads, strings))
classes = [
- tracing_backend.TraceResultImpl,
- RawTraceResultImplWrapper
+ tracing_backend.ChromeLegacyTraceResult,
+ ChromeRawTraceResultWrapper
]
for cls in classes:
- self._traceResultImplClass = cls
- super(TracingResultImplTest, self).run(result)
+ self._chromeTraceResultClass = cls
+ super(ChromeTraceResultTest, self).run(result)
def testWrite1(self):
- ri = self._traceResultImplClass([])
+ ri = self._chromeTraceResultClass([])
f = cStringIO.StringIO()
ri.Serialize(f)
v = f.getvalue()
@@ -109,7 +109,7 @@ class TracingResultImplTest(unittest.TestCase):
self.assertEquals(j['traceEvents'], [])
def testWrite2(self):
- ri = self._traceResultImplClass([
+ ri = self._chromeTraceResultClass([
'"foo"',
'"bar"'])
f = cStringIO.StringIO()
@@ -121,7 +121,7 @@ class TracingResultImplTest(unittest.TestCase):
self.assertEquals(j['traceEvents'], ['foo', 'bar'])
def testWrite3(self):
- ri = self._traceResultImplClass([
+ ri = self._chromeTraceResultClass([
'"foo"',
'"bar"',
'"baz"'])
« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py ('k') | tools/telemetry/telemetry/core/timeline/model.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698