Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: tools/perf/metrics/rendering_stats.py

Issue 29423005: telemetry: Add GetRendererProcessFromTab to timeline model. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update unit test. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/rasterize_and_record.py ('k') | tools/perf/metrics/smoothness.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/rendering_stats.py
diff --git a/tools/perf/metrics/rendering_stats.py b/tools/perf/metrics/rendering_stats.py
index 9bde896724dd87d627829203bd022b4987fda50e..024802c7c90ce9ae906105b8ae9bf754d46df06f 100644
--- a/tools/perf/metrics/rendering_stats.py
+++ b/tools/perf/metrics/rendering_stats.py
@@ -4,11 +4,9 @@
from operator import attrgetter
-RENDER_PROCESS_MARKER = 'RenderProcessMarker'
-
class RenderingStats(object):
- def __init__(self, render_process_marker, timeline_markers):
+ def __init__(self, renderer_process, timeline_markers):
"""
Utility class for extracting rendering statistics from the timeline (or
other loggin facilities), and providing them in a common format to classes
@@ -20,9 +18,8 @@ class RenderingStats(object):
All *_time values are measured in milliseconds.
"""
- assert(len(render_process_marker) == 1)
assert(len(timeline_markers) > 0)
- self.renderer_process = render_process_marker[0].start_thread.parent
+ self.renderer_process = renderer_process
self.start = timeline_markers[0].start
self.end = timeline_markers[-1].start + timeline_markers[-1].duration
« no previous file with comments | « tools/perf/measurements/rasterize_and_record.py ('k') | tools/perf/metrics/smoothness.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698