tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 29423005: telemetry: Add GetRendererProcessFromTab to timeline model.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 29423005: telemetry: Add GetRendererProcessFromTab to timeline model. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean-ups. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/metrics/smoothness_unittest.py ('k') | tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py » ('j') | tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index f8f620bc9d0fabe9d9b466d0b23d8827d656a4b2..7d83a96377af907922ee90ae840fd507597e2a33 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -256,6 +256,12 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

def StopTracing(self):

""" Stops tracing and returns the result as TraceResult object. """

+ for (i, debugger_url) in enumerate(self._browser.tabs):

+ tab = self.tab_list_backend.Get(i, None)

+ if tab:

+ tab.ExecuteJavaScript('console.time("' + debugger_url + '")')

+ tab.ExecuteJavaScript('console.timeEnd("' + debugger_url + '")')

+ self._tracing_backend.AddTabToMarkerMapping(tab, debugger_url)

return self._tracing_backend.StopTracing()

def GetProcessName(self, cmd_line):