Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: content/browser/renderer_host/media/media_stream_provider.h

Issue 29423003: Added video capture capabilities retrieval and caching to VideoCaptureManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed mechanics of Caps enumeration to be asynchronous and 2 threaded. UT adapted. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_stream_provider.h
diff --git a/content/browser/renderer_host/media/media_stream_provider.h b/content/browser/renderer_host/media/media_stream_provider.h
index 7f0ff17eb34c186a3bac8eb5f5e662ce6feec9b6..0b4bef1f66c31c3a21e6029566d51af2949b8b6d 100644
--- a/content/browser/renderer_host/media/media_stream_provider.h
+++ b/content/browser/renderer_host/media/media_stream_provider.h
@@ -23,6 +23,11 @@ namespace base {
class MessageLoopProxy;
}
+namespace media {
+class VideoCaptureCapability;
+typedef std::vector<VideoCaptureCapability> VideoCaptureCapabilities;
tommi (sloooow) - chröme 2013/10/25 14:15:34 only one space after >
mcasas 2013/10/28 12:50:08 Done.
+}
+
namespace content {
enum MediaStreamProviderError {
@@ -52,11 +57,17 @@ class CONTENT_EXPORT MediaStreamProviderListener {
virtual void DevicesEnumerated(MediaStreamType stream_type,
const StreamDeviceInfoArray& devices) = 0;
- // Called by a MediaStreamProvider when an error has occured.
+ // Called by a MediaStreamProvider when an error has occurred.
virtual void Error(MediaStreamType stream_type,
int capture_session_id,
MediaStreamProviderError error) = 0;
+ // Called by a MediaStreamProvider when available devices' formats have been
+ // enumerated.
+ virtual void DeviceCapabilitiesEnumerated(
+ const StreamDeviceInfo& device_info,
+ const media::VideoCaptureCapabilities& capabilities) {}
tommi (sloooow) - chröme 2013/10/25 14:15:34 why not pure virtual like the other methods?
mcasas 2013/10/28 12:50:08 Because the AudioInputDeviceManager also implement
+
protected:
virtual ~MediaStreamProviderListener() {}
};

Powered by Google App Engine
This is Rietveld 408576698