Added video capture capabilities retrieval and caching to VideoCaptureManager

media/video/capture/video_capture_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // VideoCaptureDevice is the abstract base class for realizing video capture
 // device support in Chromium. It provides the interface for OS dependent
 // implementations.
 // The class is created and functions are invoked on a thread owned by
 // VideoCaptureManager. Capturing is done on other threads, depending on the OS
 // specific implementation.
 
 #ifndef MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_H_
 #define MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_H_
 
 #include <list>
 #include <string>
 
 #include "base/logging.h"
 #include "base/time/time.h"
 #include "media/base/media_export.h"
+#include "media/base/video_frame.h"
 #include "media/video/capture/video_capture_types.h"

[perkj_chrome, 2013/11/06 17:05:51]

Why is this changed in this cl ? 

[mcasas, 2013/11/06 20:10:20]

I knew it will raise eyebrows, so I added a comment, but it was lost in time.
Reason: [1] "do not rely on the symbol being brought in transitively via headers
not directly included." And we use VideoFrame. Since I'm modifying the file, I
clean it up.

[1]
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Forwar...

 
 namespace media {
 
 class MEDIA_EXPORT VideoCaptureDevice {
  public:
   // Represents a capture device name and ID.
   // You should not create an instance of this class directly by e.g. setting
   // various properties directly.  Instead use
   // VideoCaptureDevice::GetDeviceNames to do this for you and if you need to
   // cache your own copy of a name, you can do so via the copy constructor.
@@ skipping 74 matching lines @@
     CaptureApiClass capture_api_class_;
 #endif  // if defined(OS_WIN)
     // Allow generated copy constructor and assignment.
   };
 
   // Manages a list of Name entries.
   class MEDIA_EXPORT Names
       : public NON_EXPORTED_BASE(std::list<Name>) {
    public:
     // Returns NULL if no entry was found by that ID.
+    // TODO(mcasas): Possibly not used anymore, double check.

[perkj_chrome, 2013/11/06 17:05:51]

You can find out by removing it and see if it compiles.

[mcasas, 2013/11/06 20:10:20]

You're a genius! I'll try right away.

It worked! Removing it.

     Name* FindById(const std::string& id);
 
     // Allow generated copy constructor and assignment.
   };
 
   class MEDIA_EXPORT Client {
    public:
     virtual ~Client() {}
 
     // Reserve an output buffer into which a video frame can be captured
@@ skipping 90 matching lines @@
   // If deallocation is done asynchronously, then the device implementation must
   // ensure that a subsequent AllocateAndStart() operation targeting the same ID
   // would be sequenced through the same task runner, so that deallocation
   // happens first.
   virtual void StopAndDeAllocate() = 0;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_H_