[signin] Generate OAuth token on Dice Signin responses

chrome/browser/signin/dice_response_handler.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/signin/dice_response_handler.h"
+
+#include "base/memory/singleton.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/signin/account_tracker_service_factory.h"
+#include "chrome/browser/signin/chrome_signin_client_factory.h"
+#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
+#include "components/keyed_service/content/browser_context_dependency_manager.h"
+#include "components/keyed_service/content/browser_context_keyed_service_factory.h"
+#include "components/signin/core/browser/account_tracker_service.h"
+#include "components/signin/core/browser/profile_oauth2_token_service.h"
+#include "components/signin/core/browser/signin_client.h"
+#include "components/signin/core/browser/signin_header_helper.h"
+#include "components/signin/core/common/profile_management_switches.h"
+#include "google_apis/gaia/gaia_auth_fetcher.h"
+#include "google_apis/gaia/gaia_constants.h"
+#include "google_apis/gaia/google_service_auth_error.h"
+
+namespace {
+
+class DiceResponseHandlerFactory : public BrowserContextKeyedServiceFactory {
+ public:
+  // Returns an instance of the factory singleton.
+  static DiceResponseHandlerFactory* GetInstance() {
+    return base::Singleton<DiceResponseHandlerFactory>::get();
+  }
+
+  static DiceResponseHandler* GetForProfile(Profile* profile) {
+    return static_cast<DiceResponseHandler*>(
+        GetInstance()->GetServiceForBrowserContext(profile, true));
+  }
+
+ private:
+  friend struct base::DefaultSingletonTraits<DiceResponseHandlerFactory>;
+
+  DiceResponseHandlerFactory()
+      : BrowserContextKeyedServiceFactory(
+            "DiceResponseHandler",
+            BrowserContextDependencyManager::GetInstance()) {
+    DependsOn(AccountTrackerServiceFactory::GetInstance());
+    DependsOn(ChromeSigninClientFactory::GetInstance());
+    DependsOn(ProfileOAuth2TokenServiceFactory::GetInstance());
+  }
+
+  ~DiceResponseHandlerFactory() override {}
+
+  // BrowserContextKeyedServiceFactory:
+  KeyedService* BuildServiceInstanceFor(
+      content::BrowserContext* context) const override {
+    if (context->IsOffTheRecord())
+      return nullptr;
+
+    Profile* profile = static_cast<Profile*>(context);
+    return new DiceResponseHandler(
+        ChromeSigninClientFactory::GetForProfile(profile),
+        ProfileOAuth2TokenServiceFactory::GetForProfile(profile),
+        AccountTrackerServiceFactory::GetForProfile(profile));
+  }
+};
+
+}  // namespace
+
+// static
+DiceResponseHandler* DiceResponseHandler::GetForProfile(Profile* profile) {
+  return DiceResponseHandlerFactory::GetForProfile(profile);
+}
+
+DiceResponseHandler::DiceResponseHandler(
+    SigninClient* signin_client,
+    ProfileOAuth2TokenService* profile_oauth2_token_service,
+    AccountTrackerService* account_tracker_service)
+    : signin_client_(signin_client),
+      profile_oauth2_token_service_(profile_oauth2_token_service),
+      account_tracker_service_(account_tracker_service) {
+  DCHECK(signin_client_);
+  DCHECK(profile_oauth2_token_service_);
+  DCHECK(account_tracker_service_);
+}
+
+DiceResponseHandler::~DiceResponseHandler() {}
+
+void DiceResponseHandler::ProcessDiceHeader(
+    const signin::DiceResponseParams& dice_params) {
+  DCHECK_EQ(switches::AccountConsistencyMethod::kDice,
+            switches::GetAccountConsistencyMethod());
+
+  switch (dice_params.user_intention) {
+    case signin::DiceAction::SIGNIN:
+      ProcessDiceSigninHeader(dice_params.obfuscated_gaia_id, dice_params.email,
+                              dice_params.authorization_code);
+      return;
+    case signin::DiceAction::SIGNOUT:
+    case signin::DiceAction::SINGLE_SESSION_SIGNOUT:
+      LOG(ERROR) << "Signout through Dice is not implemented.";
+      return;
+    case signin::DiceAction::NONE:
+      NOTREACHED() << "Invalid Dice response parameters.";
+      return;
+  }
+
+  NOTREACHED();
+  return;
+}
+
+void DiceResponseHandler::ProcessDiceSigninHeader(
+    const std::string& gaia_id,
+    const std::string& email,
+    const std::string& authorization_code) {

[msarda, 2017/06/22 09:11:31]

Let's DCHECK that gaia_id, email and authorization_code are not empty here.

[droger, 2017/06/22 12:39:07]

Done.

+  DCHECK(!gaia_auth_fetcher_);
+  DCHECK(gaia_id_.empty());
+  DCHECK(email_.empty());
+  gaia_id_ = gaia_id;
+  email_ = email;
+  gaia_auth_fetcher_ = signin_client_->CreateGaiaAuthFetcher(
+      this, GaiaConstants::kChromeSource,
+      signin_client_->GetURLRequestContext());
+  gaia_auth_fetcher_->StartAuthCodeForOAuth2TokenExchange(authorization_code);
+
+  // TODO(droger): The token exchange must complete quickly or be cancelled. Add
+  // a timeout logic.
+}
+
+void DiceResponseHandler::OnClientOAuthSuccess(
+    const ClientOAuthResult& result) {

[msarda, 2017/06/22 09:11:31]

I would also add a VLOG(1) here.

[droger, 2017/06/22 12:39:07]

Done.

+  std::string account_id =
+      account_tracker_service_->SeedAccountInfo(gaia_id_, email_);
+  profile_oauth2_token_service_->UpdateCredentials(account_id,
+                                                   result.refresh_token);
+  gaia_id_.clear();
+  email_.clear();
+  gaia_auth_fetcher_.reset();
+}
+
+void DiceResponseHandler::OnClientOAuthFailure(
+    const GoogleServiceAuthError& error) {
+  // TODO(droger): Handle authentication errors.
+  DLOG(ERROR) << "Dice OAuth failed: " << error.error_message();

[msarda, 2017/06/22 09:11:31]

Let's use VLOG in this case as it may be useful to be able to check this even
when not built in debug mode (this will be useful especially for folks that work
on Gaia).

[droger, 2017/06/22 12:39:07]

Done.

+  gaia_id_.clear();
+  email_.clear();
+  gaia_auth_fetcher_.reset();
+}