Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrameView.h

Issue 2942163002: [Refactor] Moved scrollbar creation and deletion to ScrollbarManager (Closed)
Patch Set: change ShouldUseCustomScrollbars Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrameView.h
diff --git a/third_party/WebKit/Source/core/frame/LocalFrameView.h b/third_party/WebKit/Source/core/frame/LocalFrameView.h
index 494ecb2d67ab659f74fffd49f702599216d0e489..cabc7bf3557781f9329177038a1aefea8c125e6f 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrameView.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrameView.h
@@ -68,7 +68,6 @@ namespace blink {
class AXObjectCache;
class Cursor;
class DocumentLifecycle;
-class Element;
class ElementVisibilityObserver;
class Frame;
class FloatSize;
@@ -897,13 +896,6 @@ class CORE_EXPORT LocalFrameView final
void SetHasHorizontalScrollbar(bool has_scrollbar) override;
void SetHasVerticalScrollbar(bool has_scrollbar) override;
-
- // TODO(ymalik): This should be hidden and all calls should go through
- // setHas*Scrollbar functions above.
- Scrollbar* CreateScrollbar(ScrollbarOrientation) override;
-
- protected:
- void DestroyScrollbar(ScrollbarOrientation) override;
};
LocalFrameView* ParentFrameView() const;
@@ -958,6 +950,8 @@ class CORE_EXPORT LocalFrameView final
void ContentsResized() override;
void ScrollbarExistenceMaybeChanged();
+ LayoutObject* LayoutObjectForScrollbars() const override;
+
// Methods to do point conversion via layoutObjects, in order to take
// transforms into account.
IntRect ConvertToContainingEmbeddedContentView(const IntRect&) const;
@@ -993,11 +987,6 @@ class CORE_EXPORT LocalFrameView final
// when visible.
bool HasOverlayScrollbars() const;
- // Returns true if the frame should use custom scrollbars. If true, sets
- // customScrollbarElement to the element that supplies the scrollbar's style
- // information.
- bool ShouldUseCustomScrollbars(Element*& custom_scrollbar_element) const;
-
// Returns true if a scrollbar needs to go from native -> custom or vice
// versa, or if a custom scrollbar has a stale owner.
bool NeedsScrollbarReconstruction() const;

Powered by Google App Engine
This is Rietveld 408576698