Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp

Issue 2942163002: [Refactor] Moved scrollbar creation and deletion to ScrollbarManager (Closed)
Patch Set: change ShouldUseCustomScrollbars Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/paint/PaintInvalidationCapableScrollableArea.h" 5 #include "core/paint/PaintInvalidationCapableScrollableArea.h"
6 6
7 #include "core/frame/Settings.h" 7 #include "core/frame/Settings.h"
8 #include "core/frame/UseCounter.h" 8 #include "core/frame/UseCounter.h"
9 #include "core/html/HTMLFrameOwnerElement.h" 9 #include "core/html/HTMLFrameOwnerElement.h"
10 #include "core/layout/LayoutBox.h" 10 #include "core/layout/LayoutBox.h"
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 ? WebFeature::kScrollbarUseVerticalScrollbarTrack 273 ? WebFeature::kScrollbarUseVerticalScrollbarTrack
274 : WebFeature::kScrollbarUseHorizontalScrollbarTrack); 274 : WebFeature::kScrollbarUseHorizontalScrollbarTrack);
275 break; 275 break;
276 default: 276 default:
277 return; 277 return;
278 } 278 }
279 279
280 UseCounter::Count(GetLayoutBox()->GetDocument(), scrollbar_use_uma); 280 UseCounter::Count(GetLayoutBox()->GetDocument(), scrollbar_use_uma);
281 } 281 }
282 282
283 bool PaintInvalidationCapableScrollableArea::ShouldUseCustomScrollbars(
skobes 2017/06/27 18:48:15 I think this method would make more sense on Layou
284 LayoutObject*& style_source) const {
bokan 2017/06/27 17:48:52 This method shouldn't have an output param. The ca
285 DCHECK(!style_source);
286 style_source = LayoutObjectForScrollbars();
287
288 return style_source && style_source->IsBox() &&
289 style_source->StyleRef().HasPseudoStyle(kPseudoIdScrollbar);
290 }
291
283 } // namespace blink 292 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698