components/breakpad/tools/generate_breakpad_symbols.py - Issue 294203002: Ignore exceptions when writing breakpad symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/breakpad/tools/generate_breakpad_symbols.py

Issue 294203002: Ignore exceptions when writing breakpad symbols (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/breakpad/tools/generate_breakpad_symbols.py

diff --git a/components/breakpad/tools/generate_breakpad_symbols.py b/components/breakpad/tools/generate_breakpad_symbols.py

index 6c2556605dd309a42d607b41b84273dd79446532..b868679032cd4e5eaf5dd83f1b42c281d3bbb4b4 100755

--- a/components/breakpad/tools/generate_breakpad_symbols.py

+++ b/components/breakpad/tools/generate_breakpad_symbols.py

@@ -178,9 +178,13 @@ def GenerateSymbols(options, binaries):

module_line.group(1))

mkdir_p(output_path)

symbol_file = "%s.sym" % module_line.group(2)

- f = open(os.path.join(output_path, symbol_file), 'w')

- f.write(syms)

- f.close()

+ try:

+ f = open(os.path.join(output_path, symbol_file), 'w')

+ f.write(syms)

+ f.close()

+ except:

+ # Not much we can do about this.

Lei Zhang 2014/05/23 03:02:32 Log an error at least?

+ pass

queue.task_done()

« no previous file with comments | « no previous file | no next file » | no next file with comments »