Issue 294203002: Ignore exceptions when writing breakpad symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294203002: Ignore exceptions when writing breakpad symbols (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Robert Sesek

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ignore exceptions when writing breakpad symbols There's not much we can do about this, and ignoring the exception is better than hanging the thread. The minidump_stackwalk binary will just ignore modules for which it can't find symbols so not having some symbols isn't tragic. BUG=none R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272423

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	components/breakpad/tools/generate_breakpad_symbols.py	View	1	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm https://codereview.chromium.org/294203002/diff/1/components/breakpad/tools/generate_breakpad_symbols.py File components/breakpad/tools/generate_breakpad_symbols.py (right): https://codereview.chromium.org/294203002/diff/1/components/breakpad/tools/generate_breakpad_symbols.py#newcode186 components/breakpad/tools/generate_breakpad_symbols.py:186: # Not much we can do about this. ...

6 years, 7 months ago (2014-05-23 03:02:32 UTC) #2

jochen (gone - plz use gerrit)

6 years, 7 months ago (2014-05-23 07:07:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r272423 (presubmit successful).

Expand Messages | Collapse Messages