[kernel] Fix loss of supertype arguments.

[kernel] Fix loss of supertype arguments.

Before this, if a generic class was instantiated with only dynamic,
TypeArgument::null would be used as the type argument, ignoring
types from the super.
Now it only returns TypeArguments::null if the class directly gives all
type arguments (and they are all dynamic).

Fixes #29537

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/29036d398b0523ace72cb8f89f781a58c0a63aa2

[jensj, 2017-06-15 09:46:58]

jensj@google.com changed reviewers:
+ ahe@google.com, kmillikin@google.com

[Kevin Millikin (Google), 2017-06-21 06:43:42]

LGTM.

https://codereview.chromium.org/2941983002/diff/1/runtime/vm/kernel_binary_fl...
File runtime/vm/kernel_binary_flowgraph.cc (right):

https://codereview.chromium.org/2941983002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:1687: if (builder_->ReadTag() !=
kDynamicType) {  // read ith type's tag.
Format comments as if they were sentences.  Capitalize the first word.

https://codereview.chromium.org/2941983002/diff/1/runtime/vm/kernel_binary_fl...
runtime/vm/kernel_binary_flowgraph.cc:1700: // skip rest of arguments.
'skip rest of' ==> 'Skip the rest of the'.

[jensj, 2017-06-21 08:22:46]

Description was changed from

==========
[kernel] Fix loss of supertype arguments.

Before this, if a generic class was instantiated with only dynamic,
TypeArgument::null would be used as the type argument, ignoring
types from the super.
Now it only returns TypeArguments::null if the class directly gives all
type arguments (and they are all dynamic).

Fixes #29537

BUG=
==========

to

==========
[kernel] Fix loss of supertype arguments.

Before this, if a generic class was instantiated with only dynamic,
TypeArgument::null would be used as the type argument, ignoring
types from the super.
Now it only returns TypeArguments::null if the class directly gives all
type arguments (and they are all dynamic).

Fixes #29537

BUG=
R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/29036d398b0523ace72cb8f89f781a58c0a63aa2
==========

[jensj, 2017-06-21 08:22:47]

Committed patchset #1 (id:1) manually as
29036d398b0523ace72cb8f89f781a58c0a63aa2 (presubmit successful).