Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(37)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/viz/common/DEPS
Issue
2941933002
:
viz: Convert a sync api in ServerGpuMemoryBufferManager into async. (Closed)
Patch Set: fix test build on windows
Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
base/threading/thread_restrictions.h
components/BUILD.gn
components/viz/common/BUILD.gn
components/viz/common/DEPS
components/viz/common/server_gpu_memory_buffer_manager.h
components/viz/common/server_gpu_memory_buffer_manager.cc
components/viz/common/server_gpu_memory_buffer_manager_unittest.cc
gpu/command_buffer/client/gpu_memory_buffer_manager.h
services/ui/gpu/interfaces/gpu_service.mojom
services/ui/ws/gpu_client.cc
View unified diff
|
Download patch
« no previous file with comments
|
« components/viz/common/BUILD.gn
('k') |
components/viz/common/server_gpu_memory_buffer_manager.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 "+services/ui/gpu/interfaces",
2 "+services/ui/gpu/interfaces",
3 ]
3 ]
4
5
specific_include_rules = {
6
"server_gpu_memory_buffer_manager_unittest\.cc": [
7
"+ui/gfx",
8
]
9
}
OLD
NEW
« no previous file with comments
|
« components/viz/common/BUILD.gn
('k') |
components/viz/common/server_gpu_memory_buffer_manager.h »
('j') |
no next file with comments »
Issue 2941933002: viz: Convert a sync api in ServerGpuMemoryBufferManager into async. (Closed)
Created 3 years, 6 months ago by sadrul
Modified 3 years, 6 months ago
Reviewers: reveman, kenrb, danakj, sky, jbauman
Base URL:
Comments: 76
This is Rietveld
408576698
Chromium Code Reviews
Issue 2941933002:
viz: Convert a sync api in ServerGpuMemoryBufferManager into async. (Closed)
