Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 294193005: Revert of Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object. (Closed)

Created:
6 years, 7 months ago by blundell
Modified:
6 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object. (https://codereview.chromium.org/283413002/) Reason for revert: Introduced flake on Mac: crbug.com/376550 Original issue's description: > Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object. > > The goal of this CL is to eliminate the dependence of > GoogleURLTracker(MapEntry) on NavigationController. To accomplish this goal, > GoogleURLTrackerNavigationHelper is turned into a conceptually per-tab > interface. GoogleURLTracker::OnNavigationPending() now takes in the > GoogleURLTrackerNavigationHelper with which the navigation is associated rather > than the associated NavigationController; GoogleURLTracker performs per-tab > actions by calling the navigation helper associated with the tab. > > A followup CL will turn GoogleURLTrackerNavigationHelper(Impl) into the > GoogleURLTrackerDriver interface and ContentURLTrackerDriver implementation. > > BUG=373230 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272094 TBR=pkasting@chromium.org NOTREECHECKS=true NOTRY=true BUG=373230 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -195 lines) Patch
M chrome/browser/google/chrome_google_url_tracker_client.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/google/google_url_tracker.h View 6 chunks +16 lines, -8 lines 0 comments Download
M chrome/browser/google/google_url_tracker.cc View 11 chunks +48 lines, -40 lines 0 comments Download
M chrome/browser/google/google_url_tracker_factory.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/google/google_url_tracker_map_entry.h View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/google/google_url_tracker_map_entry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/google/google_url_tracker_navigation_helper.h View 1 chunk +31 lines, -27 lines 0 comments Download
D chrome/browser/google/google_url_tracker_navigation_helper.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/google/google_url_tracker_navigation_helper_impl.h View 2 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/google/google_url_tracker_navigation_helper_impl.cc View 3 chunks +44 lines, -29 lines 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 9 chunks +68 lines, -51 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
blundell
Created Revert of Turn GoogleURLTrackerNavigationHelper(Impl) into a per-tab object.
6 years, 7 months ago (2014-05-23 12:07:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/294193005/1
6 years, 7 months ago (2014-05-23 12:08:18 UTC) #2
commit-bot: I haz the power
Change committed as 272503
6 years, 7 months ago (2014-05-23 12:10:11 UTC) #3
Peter Kasting
6 years, 7 months ago (2014-05-23 17:29:03 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698