Issue 294193003: Fix thread-interrupter shutdown on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294193003: Fix thread-interrupter shutdown on Windows. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen

Modified:
6 years, 7 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix thread-interrupter shutdown on Windows. This reworks the ThreadId on Windows to be the tid, and not an open HANDLE. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=36502

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -75 lines)			Patch
M	runtime/platform/thread.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/platform/thread_android.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/platform/thread_linux.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/platform/thread_macos.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/platform/thread_win.h	View		3 chunks	+1 line, -5 lines	0 comments	Download
M	runtime/platform/thread_win.cc	View	1	5 chunks	+22 lines, -42 lines	0 comments	Download
M	runtime/vm/os_win.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/profiler.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/thread_interrupter.cc	View		2 chunks	+17 lines, -14 lines	0 comments	Download
M	runtime/vm/thread_interrupter_win.cc	View	1	2 chunks	+17 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Anders Johnsen

6 years, 7 months ago (2014-05-22 15:12:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r36502 (presubmit successful).