Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: net/base/data_url.cc

Issue 294193002: Set response headers for data URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed #19 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/data_url.cc
diff --git a/net/base/data_url.cc b/net/base/data_url.cc
index 9699136c85fd5cff3f62270b9336e35bd4d51f74..7b1ae64ef528e579e74743b699e510014125101d 100644
--- a/net/base/data_url.cc
+++ b/net/base/data_url.cc
@@ -14,6 +14,7 @@
#include "base/strings/string_util.h"
#include "net/base/escape.h"
#include "net/base/mime_util.h"
+#include "net/http/http_util.h"
#include "url/gurl.h"
namespace net {
@@ -57,6 +58,10 @@ bool DataURL::Parse(const GURL& url, std::string* mime_type,
} else if (charset->empty() &&
iter->compare(0, kCharsetTagLength, kCharsetTag) == 0) {
charset->assign(iter->substr(kCharsetTagLength));
+ // The grammar for charset is not specially defined in RFC2045 and
+ // RFC2397. It just needs to be a token.
+ if (!net::HttpUtil::IsToken(*charset))
+ return false;
}
}

Powered by Google App Engine
This is Rietveld 408576698