Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Side by Side Diff: net/url_request/url_request_data_job.cc

Issue 294193002: Set response headers for data URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Simple implementation of a data: protocol handler. 5 // Simple implementation of a data: protocol handler.
6 6
7 #include "net/url_request/url_request_data_job.h" 7 #include "net/url_request/url_request_data_job.h"
8 8
9 #include "net/base/data_url.h" 9 #include "net/base/data_url.h"
10 #include "net/base/net_errors.h" 10 #include "net/base/net_errors.h"
11 #include "net/http/http_response_headers.h"
12 #include "url/gurl.h"
11 13
12 namespace net { 14 namespace net {
13 15
16 int URLRequestDataJob::BuildResponse(const GURL& url,
17 std::string* mime_type,
18 std::string* charset,
19 std::string* data,
20 HttpResponseHeaders* headers) {
21 if (!net::DataURL::Parse(url, mime_type, charset, data))
22 return net::ERR_INVALID_URL;
23
24 // |mime_type| set by net::DataURL::Parse() is guaranteed to be in
25 // token "/" token
26 // form. |charset| is also guaranteed to be a token.
27
28 DCHECK(!mime_type->empty());
29 DCHECK(!charset->empty());
30
31 if (headers) {
32 headers->ReplaceStatusLine("HTTP/1.1 200 OK");
33 // "charset" in the Content-Type header is specified explicitly to follow
34 // the "token" ABNF in the HTTP spec. When DataURL::Parse() call is
35 // successful, it's guaranteed that the string in |charset| follows the
36 // "token" ABNF.
37 std::string content_type_header =
38 "Content-Type: " + *mime_type + ";charset=" + *charset;
39 headers->AddHeader(content_type_header);
40 headers->AddHeader("Access-Control-Allow-Origin: *");
41 }
42
43 return net::OK;
44 }
45
14 URLRequestDataJob::URLRequestDataJob( 46 URLRequestDataJob::URLRequestDataJob(
15 URLRequest* request, NetworkDelegate* network_delegate) 47 URLRequest* request, NetworkDelegate* network_delegate)
16 : URLRequestSimpleJob(request, network_delegate) { 48 : URLRequestSimpleJob(request, network_delegate) {
17 } 49 }
18 50
19 int URLRequestDataJob::GetData(std::string* mime_type, 51 int URLRequestDataJob::GetData(std::string* mime_type,
20 std::string* charset, 52 std::string* charset,
21 std::string* data, 53 std::string* data,
22 const CompletionCallback& callback) const { 54 const CompletionCallback& callback) const {
23 // Check if data URL is valid. If not, don't bother to try to extract data. 55 // Check if data URL is valid. If not, don't bother to try to extract data.
24 // Otherwise, parse the data from the data URL. 56 // Otherwise, parse the data from the data URL.
25 const GURL& url = request_->url(); 57 const GURL& url = request_->url();
26 if (!url.is_valid()) 58 if (!url.is_valid())
27 return ERR_INVALID_URL; 59 return ERR_INVALID_URL;
28 return DataURL::Parse(url, mime_type, charset, data)? OK: ERR_INVALID_URL; 60
61 // TODO(tyoshino): Get the headers and export via
62 // URLRequestJob::GetResponseInfo().
63 return BuildResponse(url, mime_type, charset, data, NULL);
29 } 64 }
30 65
31 URLRequestDataJob::~URLRequestDataJob() { 66 URLRequestDataJob::~URLRequestDataJob() {
32 } 67 }
33 68
34 } // namespace net 69 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_data_job.h ('k') | net/url_request/url_request_data_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698