content/browser/service_worker/service_worker_context_request_handler_unittest.cc - Issue 2941883003: [ServiceWorker] Fetch event should return integrity value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler_unittest.cc

Issue 2941883003: [ServiceWorker] Fetch event should return integrity value (Closed)

Patch Set: Address yhirano's comment #78 Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/link_header_support_unittest.cc ('k') | content/browser/service_worker/service_worker_controllee_request_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler_unittest.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

index 635ad578ea196e7df07bfe5b71916e21e3566fc8..a4c656cfeed4b858036aa6e99e2e6130dc973f13 100644

--- a/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler_unittest.cc

@@ -121,8 +121,9 @@ class ServiceWorkerContextRequestHandlerTest : public testing::Test {

helper_->mock_render_process_id(), provider_host_->provider_id(),

false /* skip_service_worker */, FETCH_REQUEST_MODE_NO_CORS,

FETCH_CREDENTIALS_MODE_OMIT, FetchRedirectMode::FOLLOW_MODE,

- RESOURCE_TYPE_SERVICE_WORKER, REQUEST_CONTEXT_TYPE_SERVICE_WORKER,

- REQUEST_CONTEXT_FRAME_TYPE_NONE, nullptr);

+ std::string() /* integrity */, RESOURCE_TYPE_SERVICE_WORKER,

+ REQUEST_CONTEXT_TYPE_SERVICE_WORKER, REQUEST_CONTEXT_FRAME_TYPE_NONE,

+ nullptr);

}

protected:

@@ -253,8 +254,9 @@ TEST_F(ServiceWorkerContextRequestHandlerTest,

helper_->mock_render_process_id(), provider_host_->provider_id(),

true /* skip_service_worker */, FETCH_REQUEST_MODE_NO_CORS,

FETCH_CREDENTIALS_MODE_OMIT, FetchRedirectMode::FOLLOW_MODE,

- RESOURCE_TYPE_SERVICE_WORKER, REQUEST_CONTEXT_TYPE_SERVICE_WORKER,

- REQUEST_CONTEXT_FRAME_TYPE_NONE, nullptr);

+ std::string() /* integrity */, RESOURCE_TYPE_SERVICE_WORKER,

+ REQUEST_CONTEXT_TYPE_SERVICE_WORKER, REQUEST_CONTEXT_FRAME_TYPE_NONE,

+ nullptr);

// Verify a ServiceWorkerRequestHandler was created.

ServiceWorkerRequestHandler* handler =

ServiceWorkerRequestHandler::GetHandler(request.get());