Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: runtime/bin/file_fuchsia.cc

Issue 2941873002: [Fuchsia] Fix Platform.executable and Platform.resolvedExecutable (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/platform.h » ('j') | runtime/bin/platform_fuchsia.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file_fuchsia.cc
diff --git a/runtime/bin/file_fuchsia.cc b/runtime/bin/file_fuchsia.cc
index ef42a310d944eccec4111f62ba72dc4a93705119..ad5cb45d674efd973d04186db99c51a4ae25ace9 100644
--- a/runtime/bin/file_fuchsia.cc
+++ b/runtime/bin/file_fuchsia.cc
@@ -507,22 +507,15 @@ bool File::IsAbsolutePath(const char* pathname) {
const char* File::GetCanonicalPath(const char* pathname) {
- // TODO(MG-425): realpath() is not implemented.
-#if 0
char* abs_path = NULL;
if (pathname != NULL) {
char* resolved_path = DartUtils::ScopedCString(PATH_MAX + 1);
ASSERT(resolved_path != NULL);
- do {
- abs_path = realpath(pathname, resolved_path);
- } while ((abs_path == NULL) && (errno == EINTR));
+ abs_path = realpath(pathname, resolved_path);
ASSERT((abs_path == NULL) || IsAbsolutePath(abs_path));
ASSERT((abs_path == NULL) || (abs_path == resolved_path));
}
return abs_path;
-#else
- return pathname;
-#endif
}
« no previous file with comments | « no previous file | runtime/bin/platform.h » ('j') | runtime/bin/platform_fuchsia.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698