Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2941873002: [Fuchsia] Fix Platform.executable and Platform.resolvedExecutable (Closed)

Created:
3 years, 6 months ago by zra
Modified:
3 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Fuchsia] Fix Platform.executable and Platform.resolvedExecutable R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/07725f3dfa71cd0bb056dfd275dad98ac3ae065c

Patch Set 1 #

Total comments: 1

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -33 lines) Patch
M runtime/bin/file_fuchsia.cc View 1 chunk +1 line, -8 lines 0 comments Download
M runtime/bin/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/platform_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_fuchsia.cc View 1 2 chunks +39 lines, -24 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 6 months ago (2017-06-14 20:54:29 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2941873002/diff/1/runtime/bin/platform_fuchsia.cc File runtime/bin/platform_fuchsia.cc (right): https://codereview.chromium.org/2941873002/diff/1/runtime/bin/platform_fuchsia.cc#newcode131 runtime/bin/platform_fuchsia.cc:131: // Platform.resovledExecutable. resolved
3 years, 6 months ago (2017-06-14 22:51:35 UTC) #3
zra
3 years, 6 months ago (2017-06-15 16:05:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
07725f3dfa71cd0bb056dfd275dad98ac3ae065c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698