pylib/gyp/MSVSSettings.py - Issue 294183004: Use relative path/dir msbuild variables to map $(InputDir) and $(InputPath)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/MSVSSettings.py

Issue 294183004: Use relative path/dir msbuild variables to map $(InputDir) and $(InputPath) (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Fix for Mac trybot Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/MSVSSettings.py

diff --git a/pylib/gyp/MSVSSettings.py b/pylib/gyp/MSVSSettings.py

index 205b3b5b9be2977e550342f6c05ac885025f9fa6..b4e0a7890d2f4a18cc65614544c3e2037455b4e6 100644

--- a/pylib/gyp/MSVSSettings.py

+++ b/pylib/gyp/MSVSSettings.py

@@ -417,11 +417,11 @@ def ConvertVCMacrosToMSBuild(s):

if '$' in s:

replace_map = {

'$(ConfigurationName)': '$(Configuration)',

- '$(InputDir)': '%(RootDir)%(Directory)',

+ '$(InputDir)': '%(RelativeDir)',

'$(InputExt)': '%(Extension)',

'$(InputFileName)': '%(Filename)%(Extension)',

'$(InputName)': '%(Filename)',

- '$(InputPath)': '%(FullPath)',

+ '$(InputPath)': '%(Identity)',

'$(ParentName)': '$(ProjectFileName)',

'$(PlatformName)': '$(Platform)',

'$(SafeInputName)': '%(Filename)',

« no previous file with comments | « no previous file | pylib/gyp/generator/msvs.py » ('j') | no next file with comments »