[gardening] Skip flaky vm tests.

[gardening] Skip flaky vm tests.

Committed: https://github.com/dart-lang/sdk/commit/a14d98ecf5475f7e0db248892656900a478c70dc

[ahe, 2017-06-14 11:34:30]

ahe@google.com changed reviewers:
+ asiva@google.com, vegorov@google.com

[ahe, 2017-06-14 11:34:30]

TBR

[ahe, 2017-06-14 11:34:43]

Description was changed from

==========
[gardening] Skip flaky vm tests.
==========

to

==========
[gardening] Skip flaky vm tests.

Committed:
https://github.com/dart-lang/sdk/commit/a14d98ecf5475f7e0db248892656900a478c70dc
==========

[ahe, 2017-06-14 11:34:44]

Committed patchset #1 (id:1) manually as
a14d98ecf5475f7e0db248892656900a478c70dc (presubmit successful).

[Vyacheslav Egorov (Google), 2017-06-14 11:52:43]

lgtm

https://codereview.chromium.org/2941733002/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/2941733002/diff/1/runtime/tests/vm/vm.status#...
runtime/tests/vm/vm.status:5: # Issue 28198
I have updated the issue. We need to find an owner for these tests or delete
them.

https://codereview.chromium.org/2941733002/diff/1/runtime/tests/vm/vm.status#...
runtime/tests/vm/vm.status:16: cc/CodeImmutability: SkipSlow
This is not a flaky test, it *must* always crash. Please revert this line.

https://codereview.chromium.org/2941733002/diff/1/runtime/tests/vm/vm.status#...
runtime/tests/vm/vm.status:29: cc/Sleep: Skip # Flaky
Both issues are marked as closed. Could you either reopen an issue or open a new
one to delete this test?

[ahe, 2017-06-14 12:03:44]

Thank you, Slava!

https://codereview.chromium.org/2941733002/diff/1/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/2941733002/diff/1/runtime/tests/vm/vm.status#...
runtime/tests/vm/vm.status:5: # Issue 28198
On 2017/06/14 11:52:43, Vyacheslav Egorov (Google) wrote:
> I have updated the issue. We need to find an owner for these tests or delete
> them.

Thank you.

https://codereview.chromium.org/2941733002/diff/1/runtime/tests/vm/vm.status#...
runtime/tests/vm/vm.status:16: cc/CodeImmutability: SkipSlow
On 2017/06/14 11:52:42, Vyacheslav Egorov (Google) wrote:
> This is not a flaky test, it *must* always crash. Please revert this line.

Good catch. I didn't notice this test wasn't timing out.

https://codereview.chromium.org/2941733002/diff/1/runtime/tests/vm/vm.status#...
runtime/tests/vm/vm.status:29: cc/Sleep: Skip # Flaky
On 2017/06/14 11:52:42, Vyacheslav Egorov (Google) wrote:
> Both issues are marked as closed. Could you either reopen an issue or open a
new
> one to delete this test?

Done.