Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 294173002: Add enable_wifi_bootstrapping variable to common.gypi (Closed)

Created:
6 years, 7 months ago by Noam Samuel
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add enable_wifi_bootstrapping variable to common.gypi This should simplify ifdefs and ensure flexibility as we move to new platforms. BUG=370071 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272433

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/common.gypi View 1 5 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Noam Samuel
6 years, 7 months ago (2014-05-21 17:46:13 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 7 months ago (2014-05-21 17:47:24 UTC) #2
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 7 months ago (2014-05-21 17:49:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/294173002/1
6 years, 7 months ago (2014-05-21 19:58:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 05:10:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 05:14:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/34047)
6 years, 7 months ago (2014-05-22 05:14:06 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 7 months ago (2014-05-22 05:51:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/294173002/1
6 years, 7 months ago (2014-05-22 05:52:57 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 06:01:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 06:08:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/6526) android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/156057) chromium_presubmit ...
6 years, 7 months ago (2014-05-22 06:08:31 UTC) #12
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 7 months ago (2014-05-22 17:40:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/294173002/20001
6 years, 7 months ago (2014-05-22 17:43:18 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 22:52:19 UTC) #15
Noam Samuel
The CQ bit was unchecked by noamsml@chromium.org
6 years, 7 months ago (2014-05-22 22:54:12 UTC) #16
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 7 months ago (2014-05-22 22:54:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/294173002/20001
6 years, 7 months ago (2014-05-22 22:54:57 UTC) #18
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 07:45:42 UTC) #19
Message was sent while issue was closed.
Change committed as 272433

Powered by Google App Engine
This is Rietveld 408576698