Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: ios/web_view/BUILD.gn

Issue 2941683002: Add script to generate CronetChromeWebView.framework (Closed)
Patch Set: Respond to comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web_view/tools/build.py » ('j') | ios/web_view/tools/build.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/BUILD.gn
diff --git a/ios/web_view/BUILD.gn b/ios/web_view/BUILD.gn
index f9f0b2ec9d1b361092c86923a18895fe45397419..0bf13e3f59de306f6e174fd5595e9203a00ffd7e 100644
--- a/ios/web_view/BUILD.gn
+++ b/ios/web_view/BUILD.gn
@@ -95,7 +95,6 @@ ios_web_view_sources = [
ios_web_view_sources += ios_web_view_public_headers
ios_web_view_deps = [
- ":generate_license",
":packed_resources",
"//base",
"//components/flags_ui",
@@ -225,22 +224,81 @@ bundle_data("packed_resources") {
]
}
-action("generate_license") {
- _license_path = "$target_out_dir/LICENSE"
+if (additional_toolchains == [] || current_toolchain == default_toolchain) {
+ _package_dir = "$root_out_dir/cronet_ios_web_view"
- script = "//tools/licenses.py"
- inputs = [
- "//buildtools/$host_os/gn",
- ]
- outputs = [
- _license_path,
- ]
- args = [
- "license_file",
- rebase_path(_license_path, root_build_dir),
- "--gn-target",
- "//ios/web_view",
- "--gn-out-dir",
- ".",
- ]
+ action("cronet_ios_web_view_generate_license") {
+ _license_path = "$_package_dir/LICENSE"
+
+ script = "//tools/licenses.py"
+ inputs = [
+ "//buildtools/$host_os/gn",
+ ]
+ outputs = [
+ _license_path,
+ ]
+ args = [
+ "license_file",
+ rebase_path(_license_path, root_build_dir),
+ "--gn-target",
+ "//ios/web_view",
+ "--gn-out-dir",
+ ".",
+ ]
+ }
+
+ copy("cronet_ios_web_view_package_copy") {
+ sources = [
+ "$root_out_dir/CronetChromeWebView.framework",
+ "//AUTHORS",
+ "//chrome/VERSION",
+ ]
+ outputs = [
+ "$_package_dir/{{source_file_part}}",
+ ]
+
+ deps = [
+ ":cronet_web_view_combined",
+ ]
+ }
+
+ if (enable_dsyms) {
+ action("cronet_ios_web_view_dsym_archive") {
+ script = "//chrome/tools/build/mac/archive_symbols.py"
+
+ # These are the dSYMs that will be archived. The sources list must be
+ # the target outputs that correspond to the dSYMs (since a dSYM is a
+ # directory it cannot be listed as a source file). The targets that
+ # generate both the dSYM and binary image are listed in deps.
+ _dsyms = [ "$root_out_dir/CronetChromeWebView.dSYM" ]
+
+ sources = [
+ "$root_out_dir/CronetChromeWebView.framework",
+ ]
+
+ _output = "$_package_dir/CronetChromeWebView.dSYM.tar.bz2"
+
+ outputs = [
+ _output,
+ ]
+
+ args = [ rebase_path(_output, root_out_dir) ] +
+ rebase_path(_dsyms, root_out_dir)
+
+ deps = [
+ ":cronet_web_view_combined",
+ ]
+ }
+ } else {
+ group("cronet_ios_web_view_dsym_archive") {
+ }
+ }
+
+ group("cronet_ios_web_view_package") {
+ deps = [
+ ":cronet_ios_web_view_dsym_archive",
+ ":cronet_ios_web_view_generate_license",
+ ":cronet_ios_web_view_package_copy",
+ ]
+ }
}
« no previous file with comments | « no previous file | ios/web_view/tools/build.py » ('j') | ios/web_view/tools/build.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698