runtime/vm/stub_code_ia32.cc - Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions. (Closed)

Patch Set: address review comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code_ia32.cc

diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc

index 3a40d1e1e65bf2f8130c0c3c40c96eedcfbdbb35..513c07d2637eaa54575e46967438513ab52d8ba9 100644

--- a/runtime/vm/stub_code_ia32.cc

+++ b/runtime/vm/stub_code_ia32.cc

@@ -767,6 +767,7 @@ void StubCode::GenerateInvokeDartCodeStub(Assembler* assembler) {

__ movl(EDX, Address(EBP, kArgumentsDescOffset));

__ movl(EDX, Address(EDX, VMHandles::kOffsetOfRawPtrInHandle));

+ // No need to check for type args, disallowed by DartEntry::InvokeFunction.

// Load number of arguments into EBX.

__ movl(EBX, FieldAddress(EDX, ArgumentsDescriptor::count_offset()));

__ SmiUntag(EBX);

« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »