runtime/vm/native_entry.h - Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_entry.h

Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions. (Closed)

Patch Set: address review comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/native_entry.h

diff --git a/runtime/vm/native_entry.h b/runtime/vm/native_entry.h

index 200703f87199837ed75301a9524bd32056716e65..7a5be6e58012b4491aba7bd634b145da8bb2452a 100644

--- a/runtime/vm/native_entry.h

+++ b/runtime/vm/native_entry.h

@@ -53,7 +53,7 @@ typedef void (*NativeFunction)(NativeArguments* arguments);

#ifdef DEBUG

#define SET_NATIVE_RETVAL(args, value) \

RawObject* retval = value; \

- ASSERT(retval->IsDartInstance()); \

+ ASSERT(retval->IsDartInstance() || retval->IsTypeArguments()); \

arguments->SetReturnUnsafe(retval);

#else

#define SET_NATIVE_RETVAL(arguments, value) arguments->SetReturnUnsafe(value);

« no previous file with comments | « runtime/vm/native_arguments.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »