runtime/vm/intermediate_language_ia32.cc - Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions. (Closed)

Patch Set: address review comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language_ia32.cc

diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc

index 42da2f0ad77bc63b08030a43302c44652ba146b9..8aaf3771855e33f04242ef347ad43200b9ddad6c 100644

--- a/runtime/vm/intermediate_language_ia32.cc

+++ b/runtime/vm/intermediate_language_ia32.cc

@@ -2349,8 +2349,8 @@ void InstantiateTypeArgumentsInstr::EmitNativeCode(

__ movl(EDX, Address(EDI, 0 * kWordSize)); // Cached instantiator type args.

__ cmpl(EDX, instantiator_type_args_reg);

__ j(NOT_EQUAL, &next, Assembler::kNearJump);

- __ movl(ECX, Address(EDI, 1 * kWordSize)); // Cached function type args.

- __ cmpl(ECX, function_type_args_reg);

+ __ movl(EBX, Address(EDI, 1 * kWordSize)); // Cached function type args.

+ __ cmpl(EBX, function_type_args_reg);

__ j(EQUAL, &found, Assembler::kNearJump);

__ Bind(&next);

__ addl(EDI, Immediate(StubCode::kInstantiationSizeInWords * kWordSize));

« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intrinsifier.cc » ('j') | no next file with comments »