Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: runtime/vm/object_test.cc

Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions. (Closed)
Patch Set: Fix lookup in dart:_internal Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index 6e8de6bbc95b272e6a257b5bf659a5b052e0e86f..e04860cf6d0118f95781ed2e21b0c0871e8d4c9a 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -2566,11 +2566,12 @@ ISOLATE_UNIT_TEST_CASE(ContextScope) {
const int first_parameter_index = 0;
const int num_parameters = 0;
+ const int type_args_slot = 0;
const int first_frame_index = -1;
bool found_captured_vars = false;
int next_frame_index = parent_scope->AllocateVariables(
- first_parameter_index, num_parameters, first_frame_index, NULL,
- &found_captured_vars);
+ first_parameter_index, num_parameters, type_args_slot, first_frame_index,
Vyacheslav Egorov (Google) 2017/06/20 15:21:41 Does it make sense to make a test *with* type argu
regis 2017/06/21 04:39:04 I updated the test with a type args variable and f
+ NULL, &found_captured_vars);
EXPECT_EQ(first_frame_index, next_frame_index); // a and c not in frame.
const intptr_t parent_scope_context_level = 1;
EXPECT_EQ(parent_scope_context_level, parent_scope->context_level());

Powered by Google App Engine
This is Rietveld 408576698