Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intrinsifier.cc

Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions. (Closed)
Patch Set: Fix lookup in dart:_internal Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/dart_entry.cc ('K') | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/kernel_to_il.h » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier.cc
diff --git a/runtime/vm/intrinsifier.cc b/runtime/vm/intrinsifier.cc
index 2f641cb324abfcae7e97e46ab7d21c34aba78132..5c877cc315182936913163160cf55cd70c9197db 100644
--- a/runtime/vm/intrinsifier.cc
+++ b/runtime/vm/intrinsifier.cc
@@ -32,6 +32,7 @@ bool Intrinsifier::CanIntrinsify(const Function& function) {
THR_Print("CanIntrinsify %s ->", function.ToQualifiedCString());
}
if (!FLAG_intrinsify) return false;
+ // TODO(regis): Do we need to explicitly filter generic functions here?
rmacnak 2017/06/20 17:20:46 Only if there are errors we don't detect at link t
regis 2017/06/21 04:39:04 I updated, but kept the TODO here for now.
if (function.IsClosureFunction()) {
if (FLAG_trace_intrinsifier) {
THR_Print("No, closure function.\n");
« runtime/vm/dart_entry.cc ('K') | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/kernel_to_il.h » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698