Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: runtime/vm/compiler.cc

Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions. (Closed)
Patch Set: Fix lookup in dart:_internal Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/compiler.cc
diff --git a/runtime/vm/compiler.cc b/runtime/vm/compiler.cc
index f5a702a4b622834bf5e2607a3194e15aef3ed489..f57c690d881c63672da5bcce09690bb37b66e9ae 100644
--- a/runtime/vm/compiler.cc
+++ b/runtime/vm/compiler.cc
@@ -115,9 +115,11 @@ DECLARE_FLAG(bool, trace_irregexp);
bool UseKernelFrontEndFor(ParsedFunction* parsed_function) {
const Function& function = parsed_function->function();
- return (function.kernel_offset() > 0) ||
- (function.kind() == RawFunction::kNoSuchMethodDispatcher) ||
- (function.kind() == RawFunction::kInvokeFieldDispatcher);
+ // TODO(regis): Kernel Front End needs to allocate a local to hold type args.
+ return !FLAG_reify_generic_functions &&
+ ((function.kernel_offset() > 0) ||
Vyacheslav Egorov (Google) 2017/06/20 15:21:41 This should probably be: return (function.kerne
regis 2017/06/21 04:39:03 Done.
+ (function.kind() == RawFunction::kNoSuchMethodDispatcher) ||
+ (function.kind() == RawFunction::kInvokeFieldDispatcher));
}

Powered by Google App Engine
This is Rietveld 408576698