Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: runtime/vm/stub_code_arm.cc

Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions. (Closed)
Patch Set: address review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/scopes.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 828 matching lines...) Expand 10 before | Expand all | Expand 10 after
839 #if defined(TARGET_OS_MACOS) || defined(TARGET_OS_MACOS_IOS) 839 #if defined(TARGET_OS_MACOS) || defined(TARGET_OS_MACOS_IOS)
840 ASSERT(kExitLinkSlotFromEntryFp == -26); 840 ASSERT(kExitLinkSlotFromEntryFp == -26);
841 #else 841 #else
842 ASSERT(kExitLinkSlotFromEntryFp == -27); 842 ASSERT(kExitLinkSlotFromEntryFp == -27);
843 #endif 843 #endif
844 __ Push(R9); 844 __ Push(R9);
845 845
846 // Load arguments descriptor array into R4, which is passed to Dart code. 846 // Load arguments descriptor array into R4, which is passed to Dart code.
847 __ ldr(R4, Address(R1, VMHandles::kOffsetOfRawPtrInHandle)); 847 __ ldr(R4, Address(R1, VMHandles::kOffsetOfRawPtrInHandle));
848 848
849 // No need to check for type args, disallowed by DartEntry::InvokeFunction.
849 // Load number of arguments into R9. 850 // Load number of arguments into R9.
850 __ ldr(R9, FieldAddress(R4, ArgumentsDescriptor::count_offset())); 851 __ ldr(R9, FieldAddress(R4, ArgumentsDescriptor::count_offset()));
851 __ SmiUntag(R9); 852 __ SmiUntag(R9);
852 853
853 // Compute address of 'arguments array' data area into R2. 854 // Compute address of 'arguments array' data area into R2.
854 __ ldr(R2, Address(R2, VMHandles::kOffsetOfRawPtrInHandle)); 855 __ ldr(R2, Address(R2, VMHandles::kOffsetOfRawPtrInHandle));
855 __ AddImmediate(R2, Array::data_offset() - kHeapObjectTag); 856 __ AddImmediate(R2, Array::data_offset() - kHeapObjectTag);
856 857
857 // Set up arguments for the Dart call. 858 // Set up arguments for the Dart call.
858 Label push_arguments; 859 Label push_arguments;
(...skipping 1467 matching lines...) Expand 10 before | Expand all | Expand 10 after
2326 } 2327 }
2327 2328
2328 2329
2329 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) { 2330 void StubCode::GenerateAsynchronousGapMarkerStub(Assembler* assembler) {
2330 __ bkpt(0); 2331 __ bkpt(0);
2331 } 2332 }
2332 2333
2333 } // namespace dart 2334 } // namespace dart
2334 2335
2335 #endif // defined TARGET_ARCH_ARM 2336 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/scopes.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698