Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: runtime/vm/flow_graph_compiler_dbc.cc

Issue 2941643002: Check for a passed-in type argument vector in the prolog of generic functions. (Closed)
Patch Set: address review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_DBC. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_DBC.
6 #if defined(TARGET_ARCH_DBC) 6 #if defined(TARGET_ARCH_DBC)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 __ Move(context_reg, -local->index()); 414 __ Move(context_reg, -local->index());
415 closure_reg = context_reg; 415 closure_reg = context_reg;
416 } else { 416 } else {
417 closure_reg = -local->index() - 1; 417 closure_reg = -local->index() - 1;
418 } 418 }
419 __ LoadField(context_reg, closure_reg, 419 __ LoadField(context_reg, closure_reg,
420 Closure::context_offset() / kWordSize); 420 Closure::context_offset() / kWordSize);
421 } else if (has_optional_params && !is_optimizing()) { 421 } else if (has_optional_params && !is_optimizing()) {
422 __ LoadConstant(context_index, Object::empty_context()); 422 __ LoadConstant(context_index, Object::empty_context());
423 } 423 }
424
425 // Check for a passed type argument vector if the function is generic.
426 if (FLAG_reify_generic_functions && function.IsGeneric()) {
427 __ Comment("Check passed-in type args");
428 UNIMPLEMENTED(); // TODO(regis): Not yet supported.
429 }
424 } 430 }
425 431
426 432
427 void FlowGraphCompiler::CompileGraph() { 433 void FlowGraphCompiler::CompileGraph() {
428 InitCompiler(); 434 InitCompiler();
429 435
430 if (TryIntrinsify()) { 436 if (TryIntrinsify()) {
431 // Skip regular code generation. 437 // Skip regular code generation.
432 return; 438 return;
433 } 439 }
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) { 581 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
576 UNIMPLEMENTED(); 582 UNIMPLEMENTED();
577 } 583 }
578 584
579 585
580 #undef __ 586 #undef __
581 587
582 } // namespace dart 588 } // namespace dart
583 589
584 #endif // defined TARGET_ARCH_DBC 590 #endif // defined TARGET_ARCH_DBC
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698