Check for a passed-in type argument vector in the prolog of generic functions.

runtime/vm/object_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #include "vm/assembler.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 2548 matching lines @@
 
   test_only = false;  // Please, insert alias.
   var_c = local_scope->LookupVariable(c, test_only);
   EXPECT(var_c->is_captured());
 
   EXPECT_EQ(3, local_scope->num_variables());         // a, b, and c alias.
   EXPECT_EQ(2, local_scope->NumCapturedVariables());  // a, c alias.
 
   const int first_parameter_index = 0;
   const int num_parameters = 0;
+  const int type_args_slot = 0;
   const int first_frame_index = -1;
   bool found_captured_vars = false;
   int next_frame_index = parent_scope->AllocateVariables(
-      first_parameter_index, num_parameters, first_frame_index, NULL,
-      &found_captured_vars);
+      first_parameter_index, num_parameters, type_args_slot, first_frame_index,

[Vyacheslav Egorov (Google), 2017/06/20 15:21:41]

Does it make sense to make a test *with* type arguments, to check if we compute
things correctly?

[regis, 2017/06/21 04:39:04]

I updated the test with a type args variable and found a bug. Thanks!

+      NULL, &found_captured_vars);
   EXPECT_EQ(first_frame_index, next_frame_index);  // a and c not in frame.
   const intptr_t parent_scope_context_level = 1;
   EXPECT_EQ(parent_scope_context_level, parent_scope->context_level());
   EXPECT(found_captured_vars);
 
   const intptr_t local_scope_context_level = 5;
   const ContextScope& context_scope = ContextScope::Handle(
       local_scope->PreserveOuterScope(local_scope_context_level));
   LocalScope* outer_scope = LocalScope::RestoreOuterScope(context_scope);
   EXPECT_EQ(2, outer_scope->num_variables());
@@ skipping 2138 matching lines @@
   // utf32->utf16 conversion.
   int32_t char_codes[] = {0,      0x0a,   0x0d,   0x7f,   0xff,
                           0xffff, 0xd800, 0xdc00, 0xdbff, 0xdfff};
 
   const String& str =
       String::Handle(String::FromUTF32(char_codes, ARRAY_SIZE(char_codes)));
   EXPECT(str.Equals(char_codes, ARRAY_SIZE(char_codes)));
 }
 
 }  // namespace dart