Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 294163012: Revert of Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable. (Closed)

Created:
6 years, 7 months ago by borenet
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable. (https://codereview.chromium.org/291333007/) Reason for revert: This removed the wrong file (safely-roll-deps instead of safely-roll-blink). Now Skia's AutoRoll Bot is broken. Original issue's description: > Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable. > > "tools/safely-roll-deps /src blink" > is the replacemnt syntax. No need to keep dead code around. > > BUG=242461 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272347 TBR=maruel@google.com,borenet@chromium.org,eseidel@chromium.org,blink-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true BUG=242461 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -0 lines) Patch
A tools/safely-roll-deps.py View 1 chunk +161 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
borenet
Created Revert of Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable.
6 years, 7 months ago (2014-05-23 13:20:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/294163012/1
6 years, 7 months ago (2014-05-23 13:21:04 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 13:21:05 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-23 13:21:06 UTC) #4
M-A Ruel
On 2014/05/23 13:21:06, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 7 months ago (2014-05-23 14:08:20 UTC) #5
borenet
The CQ bit was checked by borenet@google.com
6 years, 7 months ago (2014-05-23 14:09:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/294163012/1
6 years, 7 months ago (2014-05-23 14:10:33 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 14:11:46 UTC) #8
Message was sent while issue was closed.
Change committed as 272518

Powered by Google App Engine
This is Rietveld 408576698