Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 294163005: Support ES6 weak collections in heap profiler (Closed)

Created:
6 years, 7 months ago by yurys
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Support ES6 weak collections in heap profiler BUG=chromium:376196 LOG=Y R=alph@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21460

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M src/heap-snapshot-generator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
6 years, 7 months ago (2014-05-22 15:28:31 UTC) #1
alph
other than that lgtm https://codereview.chromium.org/294163005/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://codereview.chromium.org/294163005/diff/1/test/cctest/test-heap-profiler.cc#newcode531 test/cctest/test-heap-profiler.cc:531: if (prop->GetType() != v8::HeapGraphEdge::kElement) continue; ...
6 years, 7 months ago (2014-05-22 15:41:40 UTC) #2
yurys
https://codereview.chromium.org/294163005/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://codereview.chromium.org/294163005/diff/1/test/cctest/test-heap-profiler.cc#newcode531 test/cctest/test-heap-profiler.cc:531: if (prop->GetType() != v8::HeapGraphEdge::kElement) continue; On 2014/05/22 15:41:40, alph ...
6 years, 7 months ago (2014-05-22 15:47:33 UTC) #3
yurys
Yang, please do OWNERS review
6 years, 7 months ago (2014-05-23 06:16:22 UTC) #4
Yang
On 2014/05/23 06:16:22, yurys wrote: > Yang, please do OWNERS review lgtm.
6 years, 7 months ago (2014-05-23 09:52:54 UTC) #5
yurys
6 years, 7 months ago (2014-05-23 11:05:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r21460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698