tools/metrics/histograms/extract_histograms.py - Issue 2941623002: [Cleanup] Drop the redundant "type" attribute from enum entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/extract_histograms.py

Issue 2941623002: [Cleanup] Drop the redundant "type" attribute from enum entries. (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/extract_histograms.py

diff --git a/tools/metrics/histograms/extract_histograms.py b/tools/metrics/histograms/extract_histograms.py

index c36334a7ee8ae765a82d23a6c8fa33ab0deda10f..879a749b0dc2ae35c9a9a829f3bbc1cf66bea65f 100644

--- a/tools/metrics/histograms/extract_histograms.py

+++ b/tools/metrics/histograms/extract_histograms.py

@@ -184,11 +184,6 @@ def _ExtractEnumsFromXmlTree(tree):

last_name = None

for enum in tree.getElementsByTagName('enum'):

- if enum.getAttribute('type') != 'int':

- logging.error('Unknown enum type %s', enum.getAttribute('type'))

- have_errors = True

- continue

name = enum.getAttribute('name')

if last_name is not None and name.lower() < last_name.lower():

logging.error('Enums %s and %s are not in alphabetical order',

« no previous file with comments | « tools/metrics/histograms/enums.xml ('k') | tools/metrics/histograms/print_style.py » ('j') | no next file with comments »