Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2941603002: Don't allow "none" as a runtime for dartk. (Closed)
Patch Set: Merge branch 'master' into dartk-none Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/configuration.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 145e3ddf7299f30c00b83e5d5ba44c56a316f2ea..7549f073fcd6a491185934c2b39284b46afd862a 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -761,6 +761,9 @@ class TestCase extends UniqueObject {
TestCase(this.displayName, this.commands, this.configuration,
this.expectedOutcomes,
{bool isNegative: false, TestInformation info}) {
+ // A test case should do something.
+ assert(commands.isNotEmpty);
+
if (isNegative || displayName.contains("negative_test")) {
_expectations |= IS_NEGATIVE;
}
« no previous file with comments | « tools/testing/dart/configuration.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698