Issue 2941603002: Don't allow "none" as a runtime for dartk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2941603002: Don't allow "none" as a runtime for dartk. (Closed)

Created:
3 years, 6 months ago by Bob Nystrom

Modified:
3 years, 6 months ago

Reviewers:
ahe, Bill Hesse

CC:
reviews_dartlang.org, turnidge, rmacnak

Target Ref:
refs/heads/master

Visibility:
Public.

Don't allow "none" as a runtime for dartk. Also, add a little sanity checking in TestCase. Fix #29842. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/979026abefbeb93f8ac1ee75b5498a92c8f98c91

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	tools/testing/dart/configuration.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/testing/dart/test_runner.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

3 years, 6 months ago (2017-06-14 17:31:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
979026abefbeb93f8ac1ee75b5498a92c8f98c91 (presubmit successful).