Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc

Issue 2941563002: Enable new getUserMedia audio constraints algorithm behind a flag. (Closed)
Patch Set: address miu@'s comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc b/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc
index c013665c062d2e4c75d6d37fa6eb353ef9142c9f..7e3dbb67570676232df965c09f1f19c8e6feb924 100644
--- a/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/command_line.h"
#include "base/macros.h"
#include "base/strings/stringprintf.h"
#include "content/public/browser/web_contents_delegate.h"
@@ -80,6 +81,11 @@ class WebViewMediaAccessAPITest : public WebViewAPITest {
base::StringPrintf("runTest('%s');", test_name.c_str())));
ASSERT_TRUE(test_run_listener.WaitUntilSatisfied());
}
+
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ WebViewAPITest::SetUpCommandLine(command_line);
+ command_line->AppendSwitch("use-fake-device-for-media-stream");
Devlin 2017/06/21 13:14:33 nit: maybe add a comment explaining why this is ne
Devlin 2017/06/21 13:14:33 Can we use the kUseFakeDeviceForMediaStream consta
Guido Urdaneta 2017/06/21 14:54:56 will do in the next patchset.
Guido Urdaneta 2017/06/21 14:54:56 No, due to layering rules.
Devlin 2017/06/21 19:21:26 Using the value of a constant doesn't make it less
Guido Urdaneta 2017/06/22 09:30:13 Done. I thought using the string directly was OK t
+ }
};
IN_PROC_BROWSER_TEST_F(WebViewMediaAccessAPITest, TestAllow) {
« no previous file with comments | « content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698