third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 2941533002: Break StyleImage dependency on LayoutObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2941533002: Break StyleImage dependency on LayoutObject (Closed)

Patch Set: Rebase w/HEAD Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index e896074c771bc126d1261a6779d12418335b188c..91834a0949d53b97c506ccf7384506a167979950 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -1549,7 +1549,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,

// Sub-classes that have an associated image need to override this function

// to get notified of any image change.

- virtual void ImageChanged(WrappedImagePtr, const IntRect* = nullptr) {}

+ void ImageChanged(WrappedImagePtr, const IntRect* = nullptr) override {}

ikilpatrick 2017/06/13 18:41:00 move up to other ImageChanged override.

std::pair<int, int> SelectionStartEnd() const;