Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/testing/lib/src/analyze.dart

Issue 2941493002: Analyze package:testing. (Closed)
Patch Set: Add missing test. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/testing/analysis_options.yaml ('k') | pkg/testing/test/analyze_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/analyze.dart
diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart
index af328f7aeaccc3ea6417b30b1be8346c192c64bc..fc32fd4ec25d2ab189118c0791331f9bf39a061d 100644
--- a/pkg/testing/lib/src/analyze.dart
+++ b/pkg/testing/lib/src/analyze.dart
@@ -158,9 +158,9 @@ Future<Null> analyzeUris(
if (uris.isEmpty) return;
String topLevel;
try {
- topLevel = Uri
- .directory(await git("rev-parse", <String>["--show-toplevel"]))
- .toFilePath();
+ topLevel = new Uri.directory(
+ await git("rev-parse", <String>["--show-toplevel"]).trimRight())
+ .toFilePath(windows: false);
} catch (e) {
topLevel = Uri.base.toFilePath(windows: false);
}
« no previous file with comments | « pkg/testing/analysis_options.yaml ('k') | pkg/testing/test/analyze_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698