Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2941493002: Analyze package:testing. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add missing test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
A pkg/testing/analysis_options.yaml View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/testing/lib/src/analyze.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A pkg/testing/test/analyze_test.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/testing/testing.json View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 6 months ago (2017-06-13 08:14:16 UTC) #2
Johnni Winther
lgtm
3 years, 6 months ago (2017-06-13 10:29:55 UTC) #3
ahe
Committed patchset #2 (id:20001) manually as 964384424adba12efd7cdc78bd2a652ad0dea566 (presubmit successful).
3 years, 6 months ago (2017-06-13 13:46:12 UTC) #5
scheglov
3 years, 6 months ago (2017-06-13 13:54:39 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698