Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: runtime/vm/kernel.h

Issue 2941483003: Revert "[kernel] Stream everything. Replace .kernel_function with .kernel_offset" (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/kernel_binary.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef RUNTIME_VM_KERNEL_H_ 5 #ifndef RUNTIME_VM_KERNEL_H_
6 #define RUNTIME_VM_KERNEL_H_ 6 #define RUNTIME_VM_KERNEL_H_
7 7
8 #if !defined(DART_PRECOMPILED_RUNTIME) 8 #if !defined(DART_PRECOMPILED_RUNTIME)
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "vm/allocation.h" 10 #include "vm/allocation.h"
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 422
423 423
424 class TreeNode : public Node { 424 class TreeNode : public Node {
425 public: 425 public:
426 virtual ~TreeNode(); 426 virtual ~TreeNode();
427 427
428 DEFINE_CASTING_OPERATIONS(TreeNode); 428 DEFINE_CASTING_OPERATIONS(TreeNode);
429 429
430 virtual void AcceptVisitor(Visitor* visitor); 430 virtual void AcceptVisitor(Visitor* visitor);
431 virtual void AcceptTreeVisitor(TreeVisitor* visitor) = 0; 431 virtual void AcceptTreeVisitor(TreeVisitor* visitor) = 0;
432 intptr_t kernel_offset() const { 432 intptr_t kernel_offset() const { return kernel_offset_; }
433 ASSERT(kernel_offset_ > 0);
434 return kernel_offset_;
435 }
436 bool can_stream() { return can_stream_; } 433 bool can_stream() { return can_stream_; }
437 434
438 protected: 435 protected:
439 TreeNode() : kernel_offset_(-1), can_stream_(true) {} 436 TreeNode() : kernel_offset_(-1), can_stream_(true) {}
440 437
441 // Offset for this node in the kernel-binary. If this node has a tag the 438 // Offset for this node in the kernel-binary. If this node has a tag the
442 // offset includes the tag. Can be -1 to indicate "unknown" or invalid offset. 439 // offset includes the tag. Can be -1 to indicate "unknown" or invalid offset.
443 intptr_t kernel_offset_; 440 intptr_t kernel_offset_;
444 441
445 bool can_stream_; 442 bool can_stream_;
(...skipping 3008 matching lines...) Expand 10 before | Expand all | Expand 10 after
3454 } // namespace kernel 3451 } // namespace kernel
3455 3452
3456 kernel::Program* ReadPrecompiledKernelFromBuffer(const uint8_t* buffer, 3453 kernel::Program* ReadPrecompiledKernelFromBuffer(const uint8_t* buffer,
3457 intptr_t buffer_length); 3454 intptr_t buffer_length);
3458 3455
3459 3456
3460 } // namespace dart 3457 } // namespace dart
3461 3458
3462 #endif // !defined(DART_PRECOMPILED_RUNTIME) 3459 #endif // !defined(DART_PRECOMPILED_RUNTIME)
3463 #endif // RUNTIME_VM_KERNEL_H_ 3460 #endif // RUNTIME_VM_KERNEL_H_
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/kernel_binary.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698