Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2941483003: Revert "[kernel] Stream everything. Replace .kernel_function with .kernel_offset" (Closed)

Created:
3 years, 6 months ago by jensj
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "[kernel] Stream everything. Replace .kernel_function with .kernel_offset" The commit somehow made e.g. vm-linux-release-ia32-be turn red. This reverts commit 948e2f5d7916032ed6f0bfdc316ba4f577a5ea61. BUG= Committed: https://github.com/dart-lang/sdk/commit/de5ebc5a4ea1c4977a4772e176c62f0c4015ec97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4139 lines, -1864 lines) Patch
M pkg/kernel/binary.md View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/lib/mirrors.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_finalizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/compiler.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/kernel.h View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 10 chunks +42 lines, -101 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 26 chunks +317 lines, -1593 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 13 chunks +30 lines, -12 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 10 chunks +208 lines, -4 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 25 chunks +3442 lines, -68 lines 0 comments Download
M runtime/vm/object.h View 5 chunks +13 lines, -19 lines 0 comments Download
M runtime/vm/object.cc View 12 chunks +16 lines, -26 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +42 lines, -6 lines 0 comments Download
M runtime/vm/precompiler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.h View 3 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
jensj
tbr
3 years, 6 months ago (2017-06-14 07:12:05 UTC) #2
jensj
3 years, 6 months ago (2017-06-14 07:12:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
de5ebc5a4ea1c4977a4772e176c62f0c4015ec97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698