|
|
Chromium Code Reviews|
Created:
3 years, 6 months ago by Eugene But (OOO till 7-30) Modified:
3 years, 5 months ago CC:
chromium-reviews, ios-reviews_chromium.org, Hiroshi Ichikawa, michaeldo, sdefresne Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdded ios_web_view_inttests test suite to the bots.
This test suite has just a few quick tests and should not really have
any impact on bots capacity.
BUG=None
R=baxley@chromium.org
Patch Set 1 #
Total comments: 1
Messages
Total messages: 21 (8 generated)
lgtm
The CQ bit was checked by eugenebut@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by eugenebut@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by eugenebut@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
https://codereview.chromium.org/2941443002/diff/1/ios/build/bots/tests/common... File ios/build/bots/tests/common_tests.json (right): https://codereview.chromium.org/2941443002/diff/1/ios/build/bots/tests/common... ios/build/bots/tests/common_tests.json:37: "app": "ios_web_view_inttests" Sylvain, by any chance do you know why code signature is missing for framework which does not allow launching the test? The launch failure log is here: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
Sylvain, could you please take a look at my comment. Thanks!
Sorry for no response, I'm OOO (and will update my autoreply). crbug.com/638141 may be similar. I can check when I get to my computer. On Wed, Jun 21, 2017 at 4:49 AM <eugenebut@chromium.org> wrote: > Sylvain, could you please take a look at my comment. Thanks! > > https://codereview.chromium.org/2941443002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
eugenebut@chromium.org changed reviewers: + sdefresne@chromium.org
On 2017/06/21 04:55:38, baxley wrote: > Sorry for no response, I'm OOO (and will update my autoreply). > crbug.com/638141 may be similar. I can check when I get to my computer. crbug.com/638141 is different. I think in this case we have a GN dependency problem, and ChromeWebView framework is not built with ios_web_inttest. Sylvain, by any chance do you know why ChromeWebView is not built?
On 2017/06/29 18:32:18, Eugene But wrote: > On 2017/06/21 04:55:38, baxley wrote: > > Sorry for no response, I'm OOO (and will update my autoreply). > > crbug.com/638141 may be similar. I can check when I get to my computer. > crbug.com/638141 is different. I think in this case we have a GN dependency > problem, and ChromeWebView framework is not built with ios_web_inttest. Sylvain, > by any chance do you know why ChromeWebView is not built? Looks like bots problem (related to code-signing) was resolved. Closing this one, sorry for the noise.
Description was changed from ========== Added ios_web_view_inttests test suite to the bots. This test suite has just a few quick tests and should not really have any impact on bots capacity. BUG=None R=baxley@chromium.org ========== to ========== Added ios_web_view_inttests test suite to the bots. This test suite has just a few quick tests and should not really have any impact on bots capacity. BUG=None R=baxley@chromium.org ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
