Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2941443002: Added ios_web_view_inttests test suite to the bots. (Closed)

Created:
3 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 5 months ago
Reviewers:
baxley, sdefresne
CC:
chromium-reviews, ios-reviews_chromium.org, Hiroshi Ichikawa, michaeldo, sdefresne
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added ios_web_view_inttests test suite to the bots. This test suite has just a few quick tests and should not really have any impact on bots capacity. BUG=None R=baxley@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/build/bots/tests/common_tests.json View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 21 (8 generated)
Eugene But (OOO till 7-30)
3 years, 6 months ago (2017-06-13 01:43:57 UTC) #1
baxley
lgtm
3 years, 6 months ago (2017-06-13 21:38:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941443002/1
3 years, 6 months ago (2017-06-14 01:05:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/237008)
3 years, 6 months ago (2017-06-14 02:06:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941443002/1
3 years, 6 months ago (2017-06-15 00:10:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/237834)
3 years, 6 months ago (2017-06-15 01:10:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2941443002/1
3 years, 6 months ago (2017-06-15 12:03:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/238162)
3 years, 6 months ago (2017-06-15 13:16:43 UTC) #14
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2941443002/diff/1/ios/build/bots/tests/common_tests.json File ios/build/bots/tests/common_tests.json (right): https://codereview.chromium.org/2941443002/diff/1/ios/build/bots/tests/common_tests.json#newcode37 ios/build/bots/tests/common_tests.json:37: "app": "ios_web_view_inttests" Sylvain, by any chance do you know ...
3 years, 6 months ago (2017-06-20 02:20:46 UTC) #15
Eugene But (OOO till 7-30)
Sylvain, could you please take a look at my comment. Thanks!
3 years, 6 months ago (2017-06-21 02:49:49 UTC) #16
baxley
Sorry for no response, I'm OOO (and will update my autoreply). crbug.com/638141 may be similar. ...
3 years, 6 months ago (2017-06-21 04:55:38 UTC) #17
Eugene But (OOO till 7-30)
On 2017/06/21 04:55:38, baxley wrote: > Sorry for no response, I'm OOO (and will update ...
3 years, 5 months ago (2017-06-29 18:32:18 UTC) #19
Eugene But (OOO till 7-30)
3 years, 5 months ago (2017-06-30 01:07:00 UTC) #20
On 2017/06/29 18:32:18, Eugene But wrote:
> On 2017/06/21 04:55:38, baxley wrote:
> > Sorry for no response, I'm OOO (and will update my autoreply).
> > crbug.com/638141 may be similar. I can check when I get to my computer.
> crbug.com/638141 is different. I think in this case we have a GN dependency
> problem, and ChromeWebView framework is not built with ios_web_inttest.
Sylvain,
> by any chance do you know why ChromeWebView is not built?
Looks like bots problem (related to code-signing) was resolved. Closing this
one, sorry for the noise.

Powered by Google App Engine
This is Rietveld 408576698